MindReading toolbox for SDF and latency detection#43
Open
StavHertz wants to merge 1 commit intoAllenInstitute:masterfrom
Open
MindReading toolbox for SDF and latency detection#43StavHertz wants to merge 1 commit intoAllenInstitute:masterfrom
StavHertz wants to merge 1 commit intoAllenInstitute:masterfrom
Conversation
MindReading toolbox for SDF and latency detection
|
|
NileGraddis
reviewed
Aug 28, 2018
| @@ -0,0 +1,39 @@ | |||
| import numpy as np | |||
Contributor
There was a problem hiding this comment.
There are a lot of constants hardcoded in this script that could be made into default parameter values. Instead of:
def my_function(x):
return 5 * x
write:
def my_function(x, other_number=5):
return other_number * x
This does the same thing, but is clearer and more flexible.
Contributor
|
A general comment: it is cool that you are writing standalone scripts! You can make these easier to use by allowing them to admit command line arguments. This looks like: If someone then calls: This script should print |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please let this in.